Drupal search_files.module-1.18.thl.1

2009-04-10 by Thomas Lotterer

I tried Drupal “search_files” module titled “6.x-1.x-dev 2009-Feb-05 Development snapshot”. While cycling once through a typical use case of adding, indexing, removing and unindexing I missed some features and found some bugs. Here are the issue descriptions including enhancements and bug fixes

Submitted as Drupal issue 430096

Changes between Drupal search_files 1.18 (CVS) and 1.18.thl.1

  • feature
    added dashboard as default local task to search_files menu to allow some status insight (ugly but useful)
    Hunks at original line 16 and 557
  • cleanup
    manually deleting a directory clears associated data from search_dataset, search_files_files, search_files_directories tables in a single SQL statement. Create and leverage function search_files_delete_content_by_directory_fullpath() to complement similar new but automatically called function search_files_delete_content_by_file_fullpath();
    Hunk at original line 178
  • feature
    detect PHP safe_mode, display status in dashboard and skip over shell_exec() which would fail anyway.
    At the end of hunk at original line 178 and in hunk at original line 584
  • feature
    do not confuse users with trailing slash issues.
    Hunks at original line 228289 and 314
  • feature
    print current working directory and turn relative pathes into absolute pathes
    Hunks at original line 228289 and 314
  • typo
    funciton -> function
    At the end of hunk at original line 557
  • feature
    turn hardcoded “Directory Rescan Age” into a configurable parameter
    Hunk at original line 568 and start of hunk at original line 584
  • bugfix
    configuration of “Search Label” must use #default_value not #value
    Hunk at original line 568
  • bugfix
    there is a functional gap where vanished files were not handled at all. Regularly compare database to filesystem and remove vanished files from database.
    Hunk at original line 584
  • bugfix
    while indexing files, skip over files which vanished before being indexed. Otherwise helper applications will get passed a nonexistent file name and fail.
    Hunk at original line 640
  • cleanup
    remove debugging
    Hunk at original line 715
  • bugfix
    while preparing search results, skip over files which vanished after being indexed. Otherwise functions like filectime() will get passed a nonexistent file name and fail.
    Hunk at original line 812
  • MD5 Description, Filename, Link
    d727d7c3112343ae1dafaaecce4cf2e3 search_files.module-1.18
    18c4d64e8c01943d975cd1527d18e552 search_files.module-1.18.thl.1
    83cdce5ec743594f0e6aabd885186b02 search_files.module-1.18-1.18.thl.1.diff

2 Responses to “Drupal search_files.module-1.18.thl.1”

  1. schildi Says:

    Hallo Thomas

    as I can see, you are invited for co-maintaining the module.
    Best wishes

    Reiner

  2. Thomas Lotterer Says:

    For 6.x-1.x the issue was submitted as Drupal issue 430096 and fixed.
    For 6.x-2.x the issue was submitted as Drupal issue 504204 and fixed.

Leave a Reply